Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall section refinements #592

Merged
merged 34 commits into from
Feb 28, 2025
Merged

Uninstall section refinements #592

merged 34 commits into from
Feb 28, 2025

Conversation

kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Feb 25, 2025 •
edited
Loading

This PR improves the Uninstall section with the following updates:

shainaraskas
shainaraskas reviewed Feb 25, 2025
View reviewed changes
kosabogi and others added 6 commits February 26, 2025 09:25
@kosabogi @shainaraskas
Update deploy-manage/uninstall.md
6ee4dfd 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi @shainaraskas
Update deploy-manage/uninstall.md
b2b0d8b 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi
Merge branch 'main' into uninstall
a64e536
@kosabogi
Resolving comments
23bce0b
@kosabogi
Fixing links
a597ff7
@kosabogi
Merge branch 'main' into uninstall
093dbe6
eedugon
eedugon reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, some comments added to enrich a bit the created parts, let me know your thoughts! :)

kosabogi and others added 7 commits February 27, 2025 10:51
@kosabogi @eedugon
Update deploy-manage/uninstall/uninstall-elastic-cloud-enterprise.md
6b20645 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kosabogi @eedugon
Update deploy-manage/uninstall.md
ecf859e 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kosabogi @eedugon
Update deploy-manage/uninstall.md
3f907ca 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kosabogi @eedugon
Update deploy-manage/uninstall.md
53e7e9f 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kosabogi @eedugon
Update deploy-manage/uninstall.md
600e04d 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kosabogi @eedugon
Update deploy-manage/uninstall.md
8416e8a 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kosabogi
Moves note in ECE page
99f23b8
@kosabogi kosabogi requested a review from eedugon February 27, 2025 10:03
eedugon
eedugon reviewed Feb 27, 2025
View reviewed changes
eedugon
eedugon reviewed Feb 27, 2025
View reviewed changes
kosabogi and others added 2 commits February 27, 2025 14:49
@kosabogi @eedugon
Update deploy-manage/uninstall.md
773bfc2 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kosabogi @eedugon
Update deploy-manage/uninstall.md
ec3991e 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kosabogi kosabogi requested a review from eedugon February 27, 2025 13:49
shainaraskas
shainaraskas reviewed Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking so good! sorry for another round of little things I swear it is basically done

kosabogi and others added 11 commits February 28, 2025 10:02
@kosabogi @shainaraskas
Update deploy-manage/uninstall/delete-a-cloud-deployment.md
dd40880 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi @shainaraskas
Update deploy-manage/uninstall/delete-a-cloud-deployment.md
4cb4354 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi @shainaraskas
Update deploy-manage/uninstall/delete-a-cloud-deployment.md
4934dee 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi @shainaraskas
Update deploy-manage/uninstall/delete-a-cloud-deployment.md
543289a 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi @shainaraskas
Update deploy-manage/uninstall/delete-a-cloud-deployment.md
e4fa712 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi @shainaraskas
Update deploy-manage/uninstall/uninstall-elastic-cloud-enterprise.md
0374f2a 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi @shainaraskas
Update deploy-manage/uninstall/uninstall-elastic-cloud-enterprise.md
ff8605f 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi @shainaraskas
Update deploy-manage/uninstall/uninstall-elastic-cloud-enterprise.md
086e824 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi
Merge branch 'main' into uninstall
13a3c26
@kosabogi
Resolving comments
e79aed0
@kosabogi
Merge branch 'main' into uninstall
2c42ca8
shainaraskas

This comment was marked as duplicate.

Sign in to view

kosabogi and others added 2 commits February 28, 2025 14:37
@kosabogi @shainaraskas
Update deploy-manage/uninstall/delete-a-cloud-deployment.md
89a5a94 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi @shainaraskas
Update deploy-manage/uninstall/delete-a-cloud-deployment.md
06123af 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kosabogi kosabogi merged commit cccf0ba into main Feb 28, 2025
4 checks passed
@kosabogi kosabogi deleted the uninstall branch February 28, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shainaraskas shainaraskas shainaraskas approved these changes

@eedugon eedugon Awaiting requested review from eedugon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kosabogi @eedugon @shainaraskas