Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy and manage > users and roles > cluster/deployment > roles #603

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

shainaraskas
Copy link
Collaborator

@shainaraskas shainaraskas commented Feb 26, 2025

This PR cleans up the roles section of users and roles. please take a look at all of the pages in the section - most of the pages were reflowed and some kib UI stuff was merged in to API-centric es pages

https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/603/deploy-manage/users-roles/cluster-or-deployment-auth/user-roles

@shainaraskas shainaraskas changed the title deploy and manage > users and roles > roles deploy and manage > users and roles > cluster/deployment > roles Feb 27, 2025
@shainaraskas shainaraskas marked this pull request as ready for review February 27, 2025 04:54
eedugon
eedugon previously approved these changes Feb 27, 2025
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section looks really great. It's definitely a bit complex, but the content itself is.

In my opinion the defining roles page looks a bit too long. The content is all needed and accurate, but I'd like to share some thoughts there.

As roles can be generated with Kibana UI, and the UI shows you all the parts of a role, the role structure is not that useful for the standard users (except if they plan to use Elasticsearch API to create the roles, or if they are working with remote clusters and they really need to understand how the part of remote indices work).

I'd suggest to put Role structure with all the explanations of that section maybe in a sub-doc, and keep the defining roles page with the info of the introduction and the manage roles heading with all the content.

But anyway the way it is is also good, just a bit harder to digest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants