Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds shared attributes for release doc PR URLs #1872

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 18, 2020

The Kibana and Elasticsearch documentation use "{pull}" and "{issue}" attributes with different values (e.g. https://raw.githubusercontent.com/elastic/kibana/master/docs/index.asciidoc and https://raw.githubusercontent.com/elastic/elasticsearch/master/docs/Versions.asciidoc), which can cause problems when the content is used in a shared context (such as the Installation and Upgrade Guide).

This PR defines repo-specific attributes in the shared attributes file to solve the problem.

@lcawl lcawl requested a review from KOTungseth June 18, 2020 17:34
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Minor nit: Can we swap es-issue and es-pull for consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants