Change die to return in link checks #2663

lcawl · 2023-04-12T19:55:48Z

This PR tests whether we can essentially make all link checking output a warning instead of an error by using return and say instead of die.

Relates to #2521

lib/ES/LinkCheck.pm

…c.rb

lcawl · 2023-05-12T18:15:53Z

This PR has been replaced by work in other PRs such as #2670

lcawl changed the title ~~Change die to warning in link checks~~ Change die to warn in link checks Apr 12, 2023

lcawl force-pushed the warn-only branch from d60ac37 to d7524c4 Compare April 13, 2023 05:48

Comment out die and warn instead

d5217a8

lcawl force-pushed the warn-only branch from d7524c4 to d5217a8 Compare April 13, 2023 06:10

lcawl commented Apr 13, 2023

View reviewed changes

lib/ES/LinkCheck.pm Outdated Show resolved Hide resolved

lcawl added 2 commits April 13, 2023 01:06

Update lib/ES/LinkCheck.pm

28a9a13

Change expect_failure to false in all_books_broken_link_detection_spe…

46b804a

…c.rb

lcawl changed the title ~~Change die to warn in link checks~~ Change die to return in link checks Apr 17, 2023

Change more expect_failure to false

dff1c46

lcawl force-pushed the warn-only branch from 13680ca to dff1c46 Compare April 17, 2023 23:59

Convert more checks to false in all_books_broken_link_detection_spec.rb

e84a0c9

lcawl mentioned this pull request Apr 18, 2023

Warn on master links #2649

Closed

lcawl marked this pull request as ready for review April 18, 2023 16:59

lcawl mentioned this pull request Apr 25, 2023

Add warnlinkcheck build option #2670

Merged

lcawl marked this pull request as draft April 26, 2023 01:31

lcawl closed this May 12, 2023

Provide feedback