Buildkite use pat #2919
Merged
Buildkite use pat #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f231f6d.
|
A documentation preview will be available soon.
Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
nkammah
requested review from
a team,
bmorelli25,
colleenmcginnis and
joepeeples
nkammah
commented
Feb 2, 2024
| @@ -96,6 +96,7 @@ function Cleaner(token, repo, cache_dir, tmp_dir) { | |||
| } | |||
|
|
|||
| const is_pr_closed = function (pr) { | |||
| console.info(`Checking status of https://github.com/elastic/${pr.repo}/pull/${pr.number}`); | |||
There was a problem hiding this comment.
this is extra-logging that makes it easier to understand which PR is creating issues
bmorelli25
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables the use of pat (personal access token) to perform various GitHub operations (preview-cleaner, setting commit status). This was rolled out a first time a week ago, then reverted due to un-expected issues (explained here and fixed since then).
The testing done on this PR shows the problem to be addressed for both the docs-build-pr and preview-cleaner.