Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 8.x branches to documentation build #3056

Merged
merged 17 commits into from
Sep 12, 2024
Merged

Add 8.x branches to documentation build #3056

merged 17 commits into from
Sep 12, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 5, 2024

This PR starts adding the 8.x branches to the conf.yaml (and displaying them as 8.16).

It works around breaking links to books that do not yet have 8.x branches by using URL overrides that point to master instead. For example, the link to the Kibana Guide from this Elasticsearch Guide page goes to master:

https://docs_bk_3056.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/8.16/cat.html

Copy link

github-actions bot commented Sep 5, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@lcawl
Copy link
Contributor Author

lcawl commented Sep 6, 2024

run docs-build

@lcawl lcawl marked this pull request as ready for review September 12, 2024 17:47
@lcawl lcawl requested a review from a team as a code owner September 12, 2024 17:47
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliantly implemented!
🦖🦕🐦 🐶 🐱

@lcawl lcawl merged commit 53a7366 into elastic:master Sep 12, 2024
3 checks passed
@lcawl lcawl deleted the 8x-conf branch September 12, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants