-
Notifications
You must be signed in to change notification settings - Fork 42
fix: use maintenance branches instead of tags #374
fix: use maintenance branches instead of tags #374
Conversation
🐛 Flaky test report❕ There are not known flaky tests. Test stats 🧪
|
@@ -5,6 +5,6 @@ services: | |||
- ELASTICSEARCH_HOSTS=http://elasticsearch:9200 | |||
- ELASTIC_USERNAME=elastic | |||
- ELASTIC_PASSWORD=changeme | |||
image: "docker.elastic.co/observability-ci/kibana:${kibanaTag}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdelapenya can you discuss the differences in build times and availability of images between the observability-ci and main elastic docker images? Will this change prevent us from 'getting' a fix into the test environment faster, presuming the main docker image is built only once or twice a day, and the obs-ci is presumably built much more often?
I was also thinking in a separate issue we should dry this up and up put the version portion of the semVar in a constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The observability-ci namespace is refreshed with every merge to master in beats, and for the stack they are updated automatically.
What does this PR do?
It replaces the 7.9.2 fixed version with the 7.9-SNAPSHOT aliases.
For those places where we download a configuration file (metricbeat and elastic-agent stand-alone mode) we willl use the branch instead of the tag.
Why is it important?
It will allow us to not bump the code with every patch release, using the aliases.
Checklist
make notice
in the proper directory)Author's checklist
How to test this PR locally
metricbeat
$ SUITE=metricbeat DEVELOPER_MODE=true TAGS="metricbeat" LOG_LEVEL=TRACE make -C e2e functional-test
Ingest Manager stand-alone
$ SUITE=ingest-manager DEVELOPER_MODE=true TAGS="stand_alone_mode" LOG_LEVEL=TRACE make -C e2e functional-test
Related issues
Follow-ups
As Beats' 7.9 branch is broken since August, we do not see validd binaries/docker images for the Elastic Agent base version, that's why it's sill kept with the 7.9.2 fixed version (see services.go)