-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elastic.CommonSchema.NLog - MetadataDictionary with safe values #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
nlog-metadata-protection
branch
3 times, most recently
from
September 10, 2022 18:25
76f670c
to
e9c5ce5
Compare
snakefoot
force-pushed
the
nlog-metadata-protection
branch
from
September 11, 2022 17:42
e9c5ce5
to
7a2bd5a
Compare
Jenkins run tests please |
snakefoot
force-pushed
the
nlog-metadata-protection
branch
from
January 13, 2023 19:47
4863992
to
2eb50ac
Compare
Mpdreamz
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update to support NLOG message templates defaults of ToString()
with better support for @
destructuring properties!
Jenkins run tests please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Text.Json is very fragile, and can only handle safe objects
If it was possible to control the recursion-level of the System.Text.Json to only first level (Default=32) for unsafe objects could also be nice:
https://docs.microsoft.com/en-us/dotnet/api/system.text.json.jsonserializeroptions.maxdepth