Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump target ECS version to 8.6.0 #291

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Bump target ECS version to 8.6.0 #291

merged 3 commits into from
Mar 29, 2023

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Mar 28, 2023

I wasn't initially planning on moving to 8.6.0 however I noticed we register the index templates under a derived name using {type}-{dataset}.

When releasing new version this would mean our bootstrapping would notice an old index template with the same name and therefor return early.

This PR changes that and includes the version number in the index template name: {type}-{dataset}-{ecs.version} and adjusts the index template priority based on a stable integer representation of the version number.

This means that each new ecs version library deployment can successfully bump the index templates for the target datastreams and indices.

@Mpdreamz Mpdreamz added v8.6.0 enhancement New feature or request labels Mar 28, 2023
@Mpdreamz Mpdreamz merged commit 9aec0ab into main Mar 29, 2023
@Mpdreamz Mpdreamz deleted the feature/8.6.0 branch March 29, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant