Initial implementation for ECS zerolog #1
Conversation
example_test.go
Outdated
| // {"log.level":"error","ecs.version":"1.6.0","error.message":"something bad happened","message":"An error has occured"} | ||
| } | ||
|
|
||
| // FIXME: Needs discussion on stack_trace, may not want to include as an example. |
There was a problem hiding this comment.
enabling the stack traces places absolute paths in the output; this would make the example not very portable. I can easily add a unit test that checks if the key is set in logging_test.go if we want this explicitly tested
There was a problem hiding this comment.
adding a unit test for the key sounds fine
| package spec | ||
|
|
||
| import ( | ||
| "embed" |
There was a problem hiding this comment.
I cleaned the init login by using embed.FS instead of opening/reading the spec file
| Str("file.name", file). | ||
| Int("file.line", line), | ||
| ) | ||
| } |
example_test.go
Outdated
| // {"log.level":"error","ecs.version":"1.6.0","error.message":"something bad happened","message":"An error has occured"} | ||
| } | ||
|
|
||
| // FIXME: Needs discussion on stack_trace, may not want to include as an example. |
There was a problem hiding this comment.
adding a unit test for the key sounds fine
| "os" | ||
| "time" | ||
|
|
||
| "go.elastic.co/ecszerolog" |
There was a problem hiding this comment.
Are you taking care of getting this set up? (Or is it already set up?)
There was a problem hiding this comment.
It has not been setup yet
There was a problem hiding this comment.
The repo is still private, but we should turn it public once this PR is merged and the namespace is setup.
@simitt Can you help here?
There was a problem hiding this comment.
It's basically creating a PR similar to https://github.com/elastic/infra/pull/19734 and merging once the repo is public.
| @@ -0,0 +1,143 @@ | |||
| { | |||
There was a problem hiding this comment.
After merging the initial implementation, we should enable the sync for the spec for this repo, too.
See also elastic/ecs-logging#47
There was a problem hiding this comment.
Good point. @michel-laterman Please open an issue in the observabolity-robots repository to get help.
|
|
||
| "go.elastic.co/ecszerolog" | ||
|
|
||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
We should not use that package in new code if we can. It is in 'maintenance' mode, but in general development/support for this packages has ceased.
Alternative to errors.Wrap is fmt.Errorf("...%w", ..., err). This will capture the error parameter and produce a wrapping error.
Looks like you imported that one by accident. Did you mean "errors" ?
There was a problem hiding this comment.
ok, but the pkg/errors module comes with stack tracing, do we want to support that?
There was a problem hiding this comment.
It's just used for tests here. Might be nice to have a test that also include stack traces ;)
Add an ECS compliant zerolog constructor.
The constructor function alters zerolog package variables such as
MessageFieldNamefor formatting.Most of the implementation was inspired by previous work for the ECS zap/logrus modules.