Skip to content

Add Global context fields when creating ecs_logging.StdlibFormatter #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rdifrango opened this issue Sep 1, 2021 · 6 comments · Fixed by #65
Closed

Add Global context fields when creating ecs_logging.StdlibFormatter #57

rdifrango opened this issue Sep 1, 2021 · 6 comments · Fixed by #65
Labels
agent-python

Comments

@rdifrango
Copy link
Contributor

I know that based upon the work associated with #7 that context fields can be added to a given logging record, but what I would like to set is a default group that are populated on all log records and then any that are added via the extras on a given record they are added.

So I'd like to be able to do something like:

handler.setFormatter(ecs_logging.StdlibFormatter(extra={"environment": "dev"}))

Related discussion on the nodejs logger here.
@basepi
Copy link
Contributor

basepi commented Sep 2, 2021

Seems very reasonable. Thanks!

rdifrango added a commit to rdifrango/ecs-logging-python that referenced this issue Oct 7, 2021
@rdifrango
Resolves elastic#57
6496e81 
See: elastic#57
@rdifrango rdifrango mentioned this issue Oct 7, 2021
Merged
basepi added a commit that referenced this issue Oct 27, 2021
@rdifrango @basepi
Add Global context fields to StdlibFormatter (#65)
7a4802c 
* Resolves #57

See: #57

* Update _stdlib.py

Updated the type hints.

* Fix lint (mypy and line length)

* Update _stdlib.py

* Update _stdlib.py

Co-authored-by: Difrango, Ronald <ronald.difrango@fmr.com>
Co-authored-by: Colton Myers <colton.myers@gmail.com>
@rdifrango rdifrango mentioned this issue Jan 16, 2022
Closed
@alexsanderp
Copy link

News?

@rdifrango
Copy link
Contributor Author

@alexsanderp my PR was merged but not sure there's been a release

#65

@alexsanderp
Copy link

@rdifrango Merged into main, but the latest version doesn't have the changes :(

@basepi
Copy link
Contributor

basepi commented May 16, 2022

Ah, yeah, we need to do a release here. Thanks for the reminder.

@basepi
Copy link
Contributor

basepi commented May 18, 2022

2.0.0 is now released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Global context fields to StdlibFormatter rdifrango/ecs-logging-python
3 participants
@basepi @rdifrango @alexsanderp