Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zap #15

Closed
philkra opened this issue Oct 28, 2019 · 4 comments
Closed

zap #15

philkra opened this issue Oct 28, 2019 · 4 comments
Assignees
@simitt
Labels
lang:go

Comments

@philkra
Copy link
Contributor

philkra commented Oct 28, 2019

Formatter for zap

pinging @axw & @karmi
@ph ph mentioned this issue Jan 14, 2020
Closed
@simitt simitt mentioned this issue Mar 9, 2020
Merged
@simitt
Copy link

simitt commented Mar 19, 2020

@philkra I started working on this, but do not have the permissions to assign myself, could you please assign me or change the permissions. Thank you.

simitt added a commit to elastic/ecs-logging-go-zap that referenced this issue Mar 23, 2020
@simitt
Add minimal viable version for ECS encoder for zap. (#1)
ccff3a4 
Adds minimal required ECS information to every log output, 
when using ecszap.Core and ecszap.NewJSONEncoder.
Currently uses ECS version 1.5.0. 

related to #elastic/ecs-logging#15
@simitt simitt mentioned this issue Mar 23, 2020
Closed
@philkra
Copy link
Contributor Author

philkra commented Mar 23, 2020

@simitt , I added you to the team, should have the proper permissions now. Can you confirm?

@simitt
Copy link

simitt commented Mar 23, 2020

Yes, I have permissions now, thank you.

@felixbarny
Copy link
Member

As there's https://github.com/elastic/ecs-logging-go-zap, can this be closed?

@simitt simitt closed this as completed Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simitt simitt

Labels
lang:go
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@felixbarny @simitt @philkra