Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce log.file.path and friends #770

Closed
roncohen opened this issue Mar 3, 2020 · 3 comments · Fixed by #802
Closed

Introduce log.file.path and friends #770

roncohen opened this issue Mar 3, 2020 · 3 comments · Fixed by #802
Labels

Comments

@roncohen
Copy link
Contributor

roncohen commented Mar 3, 2020

Filebeat uses log.file.path to describe the file from which a log line was harvested. There’s no such ECS field. This describes source.path which also does not seem to exist in ECS. There’s file.path which probably is meant to mean that a specific log line contained a reference to a file, rather than that the log line was read from that file. Would be great to get log.file.path into ECS.

@webmat
Copy link
Contributor

webmat commented Mar 6, 2020

Agreed.

You're right that file.* at the top level is meant to capture details about files that are mentioned in the event itself.

log.* is mostly meant to capture metadata about the source of a log, so adding log.file.path for the source of a log event would make sense.

My first instinct would be to add this single field only, not nest all of file.* at log.file.*. Makes sense?

@roncohen
Copy link
Contributor Author

roncohen commented Mar 6, 2020 via email

@webmat
Copy link
Contributor

webmat commented Mar 25, 2020

#802 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants