Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the merge date on RFC 0005 stage 2 #1158

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Set the merge date on RFC 0005 stage 2 #1158

merged 2 commits into from
Dec 3, 2020

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Dec 1, 2020

Forgot to assign the date, when merging #1028

@webmat webmat self-assigned this Dec 1, 2020
@webmat webmat requested a review from ebeahan December 1, 2020 19:32
@webmat
Copy link
Contributor Author

webmat commented Dec 1, 2020

@ebeahan 2 days in a row where I forget a detail when merging an RFC 🤦

Let's see if we get the SIP adjustments ready by tomorrow: perhaps we can bring the streak to 3 in a row 😂

@webmat webmat mentioned this pull request Dec 1, 2020
Merged
ebeahan
ebeahan requested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also capture the correction PR, similar to what was done here?

@webmat webmat force-pushed the set-rfc5-merge-date branch from 9d36986 to 283623a Compare December 3, 2020 16:20
ebeahan
ebeahan approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustment 👍

@webmat webmat merged commit 2048954 into elastic:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan approved these changes

Assignees

@webmat webmat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmat @ebeahan