Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add host metric fields to ECS (Stage 3) #1182

Merged
merged 5 commits into from
Jan 19, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Dec 9, 2020

This PR is stage 3 of the RFC for adding host metric fields into ECS.

Link to the preview of the RFC: https://github.com/kaiyan-sheng/ecs/blob/add_host_fields/rfcs/text/0005-host-metric-fields.md

@kaiyan-sheng kaiyan-sheng self-assigned this Dec 9, 2020
@webmat webmat requested review from ebeahan and removed request for webmat December 15, 2020 19:26
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kaiyan-sheng, for adding the section on the real-world implementation!

Could you add one or two additional example source documents? The AWS example format is great; it would be valuable to capture additional examples from other listed sources.

rfcs/text/0005-host-metric-fields.md Show resolved Hide resolved
rfcs/text/0005-host-metric-fields.md Outdated Show resolved Hide resolved
@kaiyan-sheng
Copy link
Contributor Author

Hi @ebeahan, I just added two more real world example source documents, and please let me know what you think. Thanks!!

@kaiyan-sheng kaiyan-sheng requested a review from ebeahan January 13, 2021 22:09
ebeahan
ebeahan previously approved these changes Jan 14, 2021
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng is there someone that can provide an o11y-side review while @exekias is away?

cc @cyrille-leclerc

@kaiyan-sheng
Copy link
Contributor Author

@ebeahan Thanks for the review! @jsoriano Could you take a look at this PR please 😬 TIA!!

@kaiyan-sheng kaiyan-sheng requested a review from jsoriano January 14, 2021 23:23
jsoriano
jsoriano previously approved these changes Jan 15, 2021
@ebeahan ebeahan dismissed stale reviews from jsoriano and themself via cd5ff1f January 19, 2021 16:27
@ebeahan ebeahan merged commit ab0c8ba into elastic:master Jan 19, 2021
@kaiyan-sheng kaiyan-sheng deleted the add_host_fields branch January 19, 2021 16:55
@dainperkins
Copy link
Contributor

I just noticed Metricbeat is currently using host.network.in|out.bytes|packets, might make a lot of sense to stick with that instead of ingress/egress and updating beats / existing indices, etc.
Its also pretty typical to see interface specific metrics described in a pure in/out perspective as theres no concept of e.g. final destination (azure, aws examples, snmp, etc.), whereas ingress/egress often refers specifically to an l2/l3 network concept of handling packets (e.g. router, switch, firewall netflow reporting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants