-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Add host metric fields to ECS (Stage 3) #1182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kaiyan-sheng, for adding the section on the real-world implementation!
Could you add one or two additional example source documents? The AWS example format is great; it would be valuable to capture additional examples from other listed sources.
Hi @ebeahan, I just added two more real world example source documents, and please let me know what you think. Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kaiyan-sheng is there someone that can provide an o11y-side review while @exekias is away?
I just noticed Metricbeat is currently using host.network.in|out.bytes|packets, might make a lot of sense to stick with that instead of ingress/egress and updating beats / existing indices, etc. |
This PR is stage 3 of the RFC for adding host metric fields into ECS.
Link to the preview of the RFC: https://github.com/kaiyan-sheng/ecs/blob/add_host_fields/rfcs/text/0005-host-metric-fields.md