Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document as-is field log.flags used by Beats #1379

Closed
wants to merge 1 commit into from

Conversation

ypid-geberit
Copy link
Contributor

Superseeds: #1372
Implements: #191
Related to: #940, #1373

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

@ebeahan
Copy link
Member

ebeahan commented Apr 23, 2021

Thanks, @ypid-geberit!

I want to open up a discussion here around log.flags to a broader group. I noticed you opened the PR as a draft, though, so I'll hold for now.

Let us know if we can help get the artifacts to build or the tests to pass.

@ypid-geberit ypid-geberit marked this pull request as ready for review April 26, 2021 15:07
@ypid-geberit
Copy link
Contributor Author

ypid-geberit commented Apr 26, 2021

The draft status might be misleading. I removed it. This PR is not intended to be merged without discussion and rework, that is what I wanted to express. Potentially event.flags is a better name. This PR basically just documents the as-is use of Beats.

So, sounds good, lets discuss it.

Building the artifacts just distracts from the changes at this stage I would say (and I did not get the full tooling to work in my env, but I got enough of it working to make great use of it internally and contribute back, ref: https://github.com/geberit/elastic-ecs).

@ebeahan
Copy link
Member

ebeahan commented Jun 29, 2021

Let's continue the discussion thread in #191 and once we have a direction finalized, we can re-open the PR.

@ebeahan ebeahan closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants