Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check that field level is set on all fields #139

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Oct 19, 2018

No description provided.

@ruflin ruflin added the review label Oct 19, 2018
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Love the fact that it's not even lowercased. Let's keep the file content strict :-)

@webmat webmat merged commit 7fe9c89 into elastic:master Oct 19, 2018
@webmat
Copy link
Contributor

webmat commented Oct 19, 2018

@ruflin Not actually sure why the build is failing. All generated files are up to date, and the script doesn't raise an exception now, as there's no missing level.

Not sure what is causing these 2 newlines to be detected in the script by git diff.

Perhaps I merged too fast :-)

@ruflin
Copy link
Member Author

ruflin commented Oct 22, 2018

I think master is fine it was just a flaky CI instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants