Tweak note about 'IDs' being keyword to also mention 'codes' #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Oct 29, 2018
README.md
Outdated
| @@ -503,11 +503,12 @@ of a breaking change with these two widely used fields in Beats. | |||
| Any future field that will be indexed for full text search in ECS will however | |||
| follow the multi-field convention where `text` indexing is nested in the multi-field. | |||
|
|
|||
| ### IDs are keywords not integers | |||
| ### IDs and codes are keywords, not integers | |||
There was a problem hiding this comment.
Are you thinking of some specific fields here?
There was a problem hiding this comment.
Yes, error codes. Came up during a discussion with @graphaelli over on #154. Just thought I would flesh out this little section here.
|
The reason I'm hesitant to merge this is because there are some instances like status_code where things are long and as I see this as a good thing. Perhaps it can be rephrased to "in most cases". |
|
Gotcha. I'll tweak accordingly. |
|
Reworded. Although I find this a bit wordy. |
ruflin
approved these changes
Nov 1, 2018
|
I agree README is getting verbose. But my plan is definitely to split off some of these discussions into secondary documentation files, to streamline the readme again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.