Remove duplicate definitions of os from host.os and user_agent.os...
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Nov 5, 2018
ruflin
approved these changes
Nov 5, 2018
|
As discussed on Slack, I would suggest to list it under |
|
@ruflin You were asking if the stuff removed was actually in line with the |
added 3 commits
November 6, 2018 09:07
…s`... With `os` now a reuseable object, it's now expected in these locations, and the field set should only be declared once. Having it (and other reuseable objects) appear correctly in `template.json` is still work to be done.
It's not an actual breaking change, it's true.
webmat
force-pushed
the
dupe-reuseable-os
branch
from
d4f3641
to
de3502e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
osnow a reuseable field set, it's now expected in these locations. The field set should only be defined once.Having it (and other reuseable field sets) appear correctly in
template.jsonis still work to be done.