Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove the http object... #171

Merged
merged 4 commits into from
Nov 7, 2018
Merged

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Nov 6, 2018

We're currently debating whether we should nest all field sets representing
protocols under network..

We're therefore taking http out of ECS for the Beta1 release. We will add it again
in the proper location when the decision has been taken.

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs a make to pass CI. Besides that LGTM:

Mathieu Martin added 3 commits November 6, 2018 13:28
We're currently debating whether we should nest the field sets representing protocols under `network.`. So we're taking `http` out of ECS for the Beta1 release.

We will add it again when the decision has been taken.
This was caused by the source file being renamed from http.yml to web-logs.yml
Copy link
Contributor

@MikePaquette MikePaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@webmat webmat merged commit 0e19080 into elastic:master Nov 7, 2018
@webmat webmat deleted the temp-rm-http branch November 7, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants