Prepare the readme intro and changelog for 1.0.0-beta1 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
MikePaquette
approved these changes
Nov 6, 2018
ruflin
reviewed
Nov 7, 2018
CHANGELOG.md
Outdated
| are not in agreement, the README.md should be considered the official spec. | ||
| The other two files are simply provided as a convenience, and are not yet | ||
| fully up to date. | ||
| * Two field sets have been temporarily removed from 1.0.0-beta.1. They will be |
There was a problem hiding this comment.
Let's not make any promises in release notes. Remove this part.
ruflin
reviewed
Nov 7, 2018
CHANGELOG.md
Outdated
| All notable changes to this project will be documented in this file based on the [Keep a Changelog](http://keepachangelog.com/) Standard. This project adheres to [Semantic Versioning](http://semver.org/). | ||
|
|
||
| ## [1.0.0-beta.1](https://github.com/elastic/ecs/tag/v1.0.0-beta.1) - 2018-11-08 |
There was a problem hiding this comment.
I would keep a section on top with #Unreleased and all the headers inside. The release part is then copied into the release notes on Github.
ruflin
reviewed
Nov 7, 2018
CHANGELOG.md
Outdated
| ## [Unreleased](https://github.com/elastic/ecs/compare/0.1.0...master) | ||
| ### Caveats with this release | ||
|
|
||
| * When the README.md file and other generated files (schema.csv and template.json) |
added 9 commits
November 7, 2018 15:15
webmat
changed the title
ruflin
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing the beta1 release.
This PR includes:
Closes #167