Use type for queryable object types for labels and annotations #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2018
|
The challenge here is that aggregations on it will not be possible, at lease in the short term. I wonder if we should still recommend it? |
|
Yeah, if it lacks terms aggregation then we shouldn't recommend it, I wonder if any other aggregation could be needed for these fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new ES datatype in development that will allow to store json objects with any field name, what will allow to have fields inside these objects with dots. This helps to avoid mapping conflicts as the ones we have seen with docker and kubernetes labels in beats.
I propose that ECS recommends the use of this type for this sort of values.
Not to be merged before the type is available in ES.