-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Risk Score Extensions - Stage 2 #2276
Open
rylnd
wants to merge
12
commits into
elastic:main
Choose a base branch
from
rylnd:risk_score_extension_stage_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Sep 19, 2023
-
* Adds Source Data example * Adds Scope of Impact section * Updates Concerns section
Configuration menu - View commit details
-
Copy full SHA for 3ba9f6a - Browse repository at this point
Copy the full SHA 3ba9f6aView commit details
Commits on Sep 28, 2023
-
Update rfcs/text/0042-risk-score-extensions.md
Co-authored-by: Eric Beahan <ebeahan@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 65447a6 - Browse repository at this point
Copy the full SHA 65447a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2024e6 - Browse repository at this point
Copy the full SHA f2024e6View commit details
Commits on Oct 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6460bab - Browse repository at this point
Copy the full SHA 6460babView commit details
Commits on Oct 26, 2023
-
Replace Alert document with Risk Score document
I misunderstood the "source data" section; a risk score document is what actually shows the proposed fields being used.
Configuration menu - View commit details
-
Copy full SHA for 6fc0186 - Browse repository at this point
Copy the full SHA 6fc0186View commit details
Commits on Dec 8, 2023
-
Add a more realistic category_1_count value
This represents the total number of alerts that were processed to create this risk score; having a larger number is both more realistic, and also highlights the fact that the number of inputs will be very small compared to this number.
Configuration menu - View commit details
-
Copy full SHA for 9cd969d - Browse repository at this point
Copy the full SHA 9cd969dView commit details -
We've added this functionality within the product, we should discuss and add these fields to ECS as well.
Configuration menu - View commit details
-
Copy full SHA for 323ed90 - Browse repository at this point
Copy the full SHA 323ed90View commit details -
More clearly state that the category score is normalized
This was previously not clear from the examples/descriptions: category scores will be normalized to the 0-100 range, and only the `calculated_score` represents the "raw" score of the entity.
Configuration menu - View commit details
-
Copy full SHA for 54c42b5 - Browse repository at this point
Copy the full SHA 54c42b5View commit details -
Add more realistic fields/values for our score document
* category scores are within 0-100 * category scores sum to the calculated_score_norm * category 5 is present since criticality is present
Configuration menu - View commit details
-
Copy full SHA for 3a21061 - Browse repository at this point
Copy the full SHA 3a21061View commit details -
Configuration menu - View commit details
-
Copy full SHA for a00f454 - Browse repository at this point
Copy the full SHA a00f454View commit details
Commits on Dec 19, 2023
-
We decided to number our risk categories based on the order in which they are introduced in kibana. Since Asset Criticality is being released next, and AC corresponds to the Entity Contexts category, it's now Category 2.
Configuration menu - View commit details
-
Copy full SHA for 7af698b - Browse repository at this point
Copy the full SHA 7af698bView commit details
Commits on Jan 5, 2024
-
Revert "Add asset criticality fields"
This reverts commit 323ed90. Conflicts: rfcs/text/0042-risk-score-extensions.md rfcs/text/0042/risk.yml
Configuration menu - View commit details
-
Copy full SHA for cd6e17c - Browse repository at this point
Copy the full SHA cd6e17cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.