Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for missing license headers #2378

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Sep 6, 2024

Add make check_license_headers as a test workflow step, in order to detect any yaml or py files without the required license header.

  • Have you signed the contributor license agreement? y
  • Have you followed the contributor guidelines? y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? n/a
  • If submitting code/script changes, have you verified all tests pass locally using make test? y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? n/a
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. y
  • Have you added an entry to the CHANGELOG.next.md? n/a

Add `make check_license_headers` as a test workflow step, in order to detect any
yaml or py files without the required license header.
@stbischof
Copy link
Contributor

https://github.com/marketplace/actions/license-eye-header

You may want to use this ci task

@stbischof
Copy link
Contributor

stbischof commented Sep 12, 2024

@mjwolf

Would be also nice if you not just check for

Licensed to Elasticsearch B.V.

But also check fot the Apache License

If its okay, i can do a pr with the ci Plugin. This way we can see this an an extra check in the pr

@mjwolf
Copy link
Contributor Author

mjwolf commented Sep 23, 2024

@mjwolf

Would be also nice if you not just check for

Licensed to Elasticsearch B.V.

But also check fot the Apache License

If its okay, i can do a pr with the ci Plugin. This way we can see this an an extra check in the pr

Hi @stbischof, if you'd like to create another PR for this, I'd appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants