Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Stage 0: Introducing new fields in file/dll/process fields #2387

Merged
merged 7 commits into from
Oct 15, 2024
Merged

[RFC] Stage 0: Introducing new fields in file/dll/process fields #2387

merged 7 commits into from
Oct 15, 2024

Conversation

AsuNa-jp
Copy link
Contributor

@AsuNa-jp AsuNa-jp commented Sep 25, 2024 •
edited
Loading

  • Have you signed the contributor license agreement?
    Yes
  • Have you followed the contributor guidelines?
    Yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
    Yes
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

About this PR

I've created the following PR for OpenTelemetry. Once this PR is merged, I plan to create the Stage 1 RFC PR as well. This Stage 0 PR was created to establish a basis for discussion.

@AsuNa-jp AsuNa-jp requested a review from a team as a code owner September 25, 2024 10:49
@AsuNa-jp AsuNa-jp self-assigned this Sep 25, 2024
@AsuNa-jp AsuNa-jp changed the title [RFC] Stage 0: Introducing new field in file fields [RFC] Stage 0: Introducing new fields in file fields Sep 25, 2024
@AsuNa-jp AsuNa-jp changed the title [RFC] Stage 0: Introducing new fields in file fields [RFC] Stage 0: Introducing new fields in file/dll/process fields Oct 9, 2024
mjwolf
mjwolf approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@mjwolf mjwolf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me for RFC stage 0.

@mjwolf mjwolf merged commit 8a2c649 into elastic:main Oct 15, 2024
2 checks passed
mjwolf added a commit that referenced this pull request Oct 15, 2024
@AsuNa-jp @mjwolf
[RFC] Stage 0: Introducing new fields in file/dll/process fields (#2387)
e7fcda3 
---------

Co-authored-by: Michael Wolf <michael.wolf@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjwolf mjwolf mjwolf approved these changes

@trisch-me trisch-me Awaiting requested review from trisch-me

Assignees

@AsuNa-jp AsuNa-jp

Labels
backport-8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsuNa-jp @mjwolf