Backport #347 and #390 to 1.0: Generator for asciidoc representation of all ECS fields (#347) #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code generates both the index page for the fields section, and the detailed page for each fieldset. Also in this PR: - If `short` not set, copy `definition` to it - If `short` contains \n, fail. Beginning of an ECS linter. - Beef up the local file imports in tests. - autopep8 ignore E402, in order to leave local imports alone - Create generators/ecs_helpers.py, to start reusing functionality beween generators
ruflin
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #347 and #390 to 1.0 branch. Original message:
This code generates both the index page for the fields section, and the
detailed page for each fieldset.
Also in this PR:
shortnot set, copydefinitionto itshortcontains \n, fail. Beginning of an ECS linter.generators
Note: #390 was just a missing changelog