Backport #454 to 1.0: Format port numbers and numeric IDs as strings #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need to merge this only after 1.0.1 has been released. Related to this, 3 commits appear in this PR that are related to the pending 1.0.1 release. Only the latest commit is relevant in this backport PR. |
This was referenced May 23, 2019
ruflin
approved these changes
May 24, 2019
Changes the display format of things like port numbers and PIDs to string where appropriate. Changed fields are: client.port destination.port event.severity event.sequence (cherry-pick note: not in 1.0) http.response.status_code process.pid process.ppid process.pgid (cherry-pick note: not in 1.0) process.thread.id server.port source.port url.port
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
May 24, 2019
…trings (elastic#467) Backport of PR elastic#454 to 1.0 branch. Original message: Changes the display format of things like port numbers and PIDs to string where appropriate. Changed fields are: client.port destination.port event.severity event.sequence (cherry-pick note: not in 1.0) http.response.status_code process.pid process.ppid process.pgid (cherry-pick note: not in 1.0) process.thread.id server.port source.port url.port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #454 to 1.0 branch. Original message:
Changes the display format of things like port numbers and PIDs to string where appropriate. Changed fields are:
client.port
destination.port
event.severity
event.sequence (backport note: not in 1.0)
http.response.status_code
process.pid
process.ppid
process.pgid (backport note: not in 1.0)
process.thread.id
server.port
source.port
url.port