-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#475) Add support for host and process uptime fields #477
Conversation
Hi @mdelapenya, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
@mdelapenya Thanks for updating the PR. My suggestion was to make it seconds, but I should have been more explicit: the unit shouldn't be part of the field name. We should have the description state that it's seconds. In the context of the ecs-metrics experimental branch, we're even considering making this directive official, see #481 |
Oh my! I understood totally the opposite from the thread :) Also reading how prometheus folks define metrics made me think that way. Anyway, I'll revert back to the original, where units were explicitly described in fields comments/descriptions Thanks! |
PR updated with your suggestions, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick adjustments. I have a few requests still, and then we'll be good.
schemas/server.yml
Outdated
@@ -74,3 +74,10 @@ | |||
example: 12 | |||
description: > | |||
Packets sent from the server to the client. | |||
|
|||
- name: uptime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I hadn't noticed this. The field set server
is meant to describe the server side of a network connection. We have two pairs: client/server and source/destination. As such, this isn't the right place for this.
server.uptime
should be moved to host.uptime
:-)
Let's also make host.uptime
extended for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is extended
a matter of adding a level: extended
, or is there any other consideration?
schemas/process.yml
Outdated
@@ -87,6 +87,13 @@ | |||
description: > | |||
The time the process started. | |||
|
|||
- name: uptime | |||
level: core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this extended
for now.
Changes ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge at your convenience :-) No need to backport or anything special.
Thanks @webmat!! What about the docs? Is this something I have to handle too? |
@mdelapenya Docs were generated automatically. |
Yes, generated every half hour. But note that master != current on the docs. So you can see your contribution if you go to the docs and select "master" in the version selector. |
Closes #475
What does this PR do?
This PR adds fields for
process.uptime
andserver.uptime
. As suggested by @webmat, the uptime field will be measured in seconds.