Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Risk Fields #518

Closed
wants to merge 10 commits into from
Closed

Risk Fields #518

wants to merge 10 commits into from

Conversation

dainperkins
Copy link
Contributor

Added risk fields for scoring and categorizing atomic users / groups / hosts / cloud / containers etc.

Copy link
Contributor

@MikePaquette MikePaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the event.risk.score algorithm should be specified here. Also, dropped a few comments.

schemas/risk.yml Outdated Show resolved Hide resolved
schemas/risk.yml Outdated
level: extended
type: keyword
description: MD5 hash.
description: locally relevant label to describe the risk type of asset or data identified either
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enhance this definition to make it clearer to those transforming data what they should put here? What is the relationship of this field value to the risk.score? Do we expect this to be an array, holding multiple values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An array could be helpful, certainly I can see applying PCI & IAM or PCI & Security, etc.

schemas/risk.yml Outdated
level: extended
type: keyword
description: SHA512 hash.
example: 1-10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really just an example, or should we define this must contain a 0-10 value? At the least, we should recommend a 0-10 scoring system.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the scores should be 0-10, matches all of the existing CVE/CVSS etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might help to consider how we would apply asset / resource risk levels to a normalized scoring system to prioritize signals by business risk - tho I suppose we could allow for multiples.

@dainperkins
Copy link
Contributor Author

dainperkins commented Aug 13, 2019 via email

@dainperkins
Copy link
Contributor Author

@MikePaquette
I changed risk.label to be risk.tag to get past the reuse of "label"

Array throws an error when I try to run make (I think @webmat said something about that previously) so I left it as keyword.

Do you still think there needs to be more in terms of usage of risk.tag? Trying to allow for whatever makes the most sense in any given environment, actually now that I think of it, event.risk.tag could easily be a concatenation of the individual risk tags from user/group/ips/file, etc.

updated Risk Fields
@MikePaquette
Copy link
Contributor

@dainperkins thanks for making the change. I do like the concept of "tags" being added to a risk field at various points, and possibly aggregating them in event.risk.tag.

From a field naming perspective .tag has a similar potential for confusion, this time with the ECS tags field. Would like @webmat to weigh in with his thoughts on whether this is a significant concern.

Question: With this change (adding risk.* fields), are you suggesting that we deprecate current ECS fields event.risk_score and/or event.risk_score_norm ?

Or do we keep event.risk_score_norm as defined, as a 0 to 100 scale of risk associated with the event? That way, application developers can build "aggregate risk" logic and visualizations based on the event.risk_score_norm field, but it will be up to the users to populate the underlying *.risk.score fields based on their environment.

I continue to lean toward specifying the numeric scale for risk.score in the ECS field definition.

@dainperkins
Copy link
Contributor Author

dainperkins commented Aug 28, 2019 via email

@dainperkins
Copy link
Contributor Author

@MikePaquette How about risk.scope (thinking of PCI in scope / out of scope from an Audit perspective instead of tag/label

I think pulling risk fields out of nesting with event makes more sense - that way theres a specific place for event risk (e.g. palo says this is a high risk alert) as well as normalized_risk for business level sorting of signals (which combines signal risk with some d&d style modifier based on assets, users, zones, etc...

removed "event." nesting
renamed risk.tag to risk.scope
updated text
removed event nesting
changed .tag to .scope
updated text, etc
@ebeahan
Copy link
Member

ebeahan commented Feb 9, 2021

@dainperkins We're going to close this out for now as it's been opened for a while without activity. If you want to move forward, let's open a stage 0 RFC proposal to capture these ideas.

@ebeahan ebeahan closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants