Add error.type field #566
Merged
Add error.type field #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Sep 23, 2019
schemas/error.yml
Outdated
| @@ -29,6 +29,12 @@ | |||
| description: > | |||
| Error code describing the error. | |||
|
|
|||
| - name: type | |||
| level: core | |||
There was a problem hiding this comment.
I kind of agree that this should be core but in general I would try to have as little field as possible in core as we will not get them "out there" anymore :-) Could we make it extended for now?
ruflin
reviewed
Sep 23, 2019
| - name: type | ||
| level: core | ||
| type: keyword | ||
| description: > |
There was a problem hiding this comment.
Could you add an example under example key? Would also be great to have at least 2 examples in the description. The reason I'm insisting on this is that type fields are always these "well we could fit everything in here" and its always hard to explain what is in. Having example should help.
There was a problem hiding this comment.
Added an example field but could not come up with a good second example for the description
ruflin
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I tried to map the exception class name to error.code.
But I don't think that's the best place for that.
In APM we also have both a code and a type for an exception.