Add entity_id for process and process.parent #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Suggesting a minor addition to the description.
But I'm good with this in any case. Thanks @andrewstucki!
|
And 👍 on keeping the Beats field name. |
|
Oof, second ☕️ hasn't kicked in yet, it seems. Another request: please add a changelog entry :-) |
|
Let's wait for @rw-access to chime in as well. You can merge after that :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the unique process identification field discussed in #672. We settled on allowing ECS users to use their own implementation-specific values in this field in order to support multiple types of data shippers that may have different requirements around the identifier generation. That said, there's still room for future discussion on some sort of standard generation algorithm that would allow us to correlate processes across multiple sources.
The name corresponds to what beats are already filling in for their unique identifier.