Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple components in changelog renderer template #63

Closed
endorama opened this issue Jun 15, 2022 · 2 comments · Fixed by #116
Closed

Support multiple components in changelog renderer template #63

endorama opened this issue Jun 15, 2022 · 2 comments · Fixed by #116
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@endorama
Copy link
Member

#55 renderer implementation does not support multiple component, and the value is hardcoded to {agent}.

The renderer should rely on the component field of the fragment instead (by grouping entries kind and then by component).

Reference template: https://github.com/elastic/observability-docs/blob/5e2f16b351769a2d9ed7373d5e3290c16498eefa/docs/en/ingest-management/release-notes/release-notes-8.2.asciidoc

@endorama endorama added the enhancement New feature or request label Aug 24, 2022
@endorama endorama added this to the v0.3.0 milestone Sep 5, 2022
@endorama
Copy link
Member Author

endorama commented Sep 5, 2022

We should be able to configure a map with valid components and their "human readable" counterparts.

Components should not be a free form field.

@lucian-ioan lucian-ioan self-assigned this Sep 19, 2022
@endorama endorama modified the milestones: v0.3.0, v0.4.0 Sep 20, 2022
@endorama
Copy link
Member Author

We reject any fragment whose component is not in the list of valid components. If the list is empty we force the component field in fragment to be empty as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants