Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement default renderer #55

Merged
merged 5 commits into from
Jun 15, 2022
Merged

Implement default renderer #55

merged 5 commits into from
Jun 15, 2022

Conversation

endorama
Copy link
Member

@endorama endorama commented Jun 9, 2022

This PR provides the first implementation of the default changelog renderer.

The default renderer renders Asciidoc following the format of https://github.com/elastic/observability-docs/blob/5e2f16b351769a2d9ed7373d5e3290c16498eefa/docs/en/ingest-management/release-notes/release-notes-8.2.asciidoc

Closes #46

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-13T15:00:04.977+0000

  • Duration: 3 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 65
Skipped 0
Total 65

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Implement a basic renderer for consolidated changelog that outputs
Asciidoc following the format of https://github.com/elastic/observability-docs/blob/5e2f16b351769a2d9ed7373d5e3290c16498eefa/docs/en/ingest-management/release-notes/release-notes-8.2.asciidoc

Notable differences:
- support for multiple components
- support for details and impact for breaking changes and known issues
@endorama endorama marked this pull request as ready for review June 13, 2022 14:59
Copy link
Collaborator

@lucian-ioan lucian-ioan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally and it's working as expected.

@endorama endorama merged commit e6c2737 into main Jun 15, 2022
@endorama endorama deleted the renderer branch June 15, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create initial default renderer
3 participants