Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle missing failure case to URL extraction #120

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

endorama
Copy link
Member

The current code check to determine a valid URL didn't take into
account this particular case which resulted in a panic at runtime.

The current code check to determine a valid URL didn't take into
account this particular case which resulted in a panic at runtime.
@endorama endorama added this to the v0.4.0 milestone Oct 31, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-31T15:27:16.161+0000

  • Duration: 3 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 72
Skipped 0
Total 72

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@endorama endorama removed this from the v0.4.0 milestone Oct 31, 2022
@endorama endorama merged commit 5b8321d into main Nov 3, 2022
@endorama endorama deleted the builder-url-extracion-fix branch November 3, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants