Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove : from filenames #143

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Remove : from filenames #143

merged 2 commits into from
Jun 19, 2023

Conversation

endorama
Copy link
Member

Using : char in filenames is only supported on Linux, thus this may break changelog consolidation after creating a changelog fragment (either locally or in CI).

This PR sanitize filename for : char too, removing it.

More about supported chars in filenames: https://stackoverflow.com/a/35352640

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-19T10:18:20.564+0000

  • Duration: 4 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 85
Skipped 0
Total 85

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@endorama endorama merged commit cac217e into main Jun 19, 2023
5 checks passed
@endorama endorama deleted the fragment-filename-sanitize branch June 19, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants