Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance cmd tests #50

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Enhance cmd tests #50

merged 4 commits into from
Jun 8, 2022

Conversation

endorama
Copy link
Member

@endorama endorama commented Jun 7, 2022

Small changes to cmd package tests to suppress log messages and avoid variable override discovered in #48

cmd variable in test functions was overriding cmd package import,
but this was not noted because it was not used after the initial
command initialization.

Remove this confusion by using a different variable.
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-07T17:14:25.505+0000

  • Duration: 2 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 50
Skipped 0
Total 50

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@endorama endorama merged commit 14b0f28 into main Jun 8, 2022
@endorama endorama deleted the cmd-tests branch June 8, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants