-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial instructions for release #56
Conversation
docs/usage.md
Outdated
* From the root folder of the repository run: | ||
|
||
``` | ||
$ elastic-agent-changelog-tool build --version x.y.z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command will need some additional option to specific the repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being done in #57: a --owner
and --repo
flags are added to this command for this purpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now available
* From the root folder of the repository run: | ||
|
||
``` | ||
$ elastic-agent-changelog-tool build --version x.y.z --owner <owner> --repo <repo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@endorama @LucianPy if there any default value for owner
? If not, should we make elastic
the default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the default owner is already elastic
:
elastic-agent-changelog-tool/cmd/root.go
Line 11 in 7c056a9
const defaultOwner = "elastic" |
The default repo
is beats
, we may want to update it to elastic-agent
.
docs/usage.md
Outdated
``` | ||
$ elastic-agent-changelog-tool render --version x.y.z | ||
``` | ||
* This will generate an asciidoc fragment in __TODO__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at #62 the output will be generated in the folder specified by the rendered_changelog_destination
setting. What is the default value for this setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value is the current folder (.
):
viper.SetDefault("rendered_changelog_destination", ".") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me the changes lftm, I will let @endorama answer the other questions
Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
Targeting the 0.2.0. We will need to add the instructions for the rendering step.