Add cleanup command #64
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
cmd/cleanup.go
Outdated
| return nil | ||
| }, | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| path, err := cmd.Flags().GetString("path") |
There was a problem hiding this comment.
Please use fragment_location instead. You can get it with viper.GetString("fragment_location")
cmd/cleanup.go
Outdated
| }, | ||
| } | ||
|
|
||
| cleanupCmd.Flags().String("path", "changelog/fragments", "The folder where fragments are stored.") |
There was a problem hiding this comment.
Remove this flag, as is possible to override this value overriding fragment_path configuration setting.
cmd/cleanup.go
Outdated
| return fmt.Errorf("error parsing flag 'path': %w", err) | ||
| } | ||
|
|
||
| err = fs.RemoveAll(path) |
There was a problem hiding this comment.
I was wondering if this implementation (where the entire folder is removed and recreated) is too greedy and can produce unexpected results. I'm thinking about the case in which users adds different files (non-YAML) in the fragments folder that get deleted by this implementation.
What do you think?
Adds
cleanupcommand which has a flag namedpath, by default it ischangelog/fragments.This command removes all fragments from the path.
From the root of the repository run:
Closes: #52