fix(logp): TestConfigureWithCore fails with Go 1.24 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cmd/vet in Go 1.24 reports printf calls with non-const format and no args, causing one test in logp to fail. See golang/go#60529. ``` $ go install golang.org/dl/gotip@latest $ gotip download $ gotip test ./logp -count=1 logp/core_test.go:714:7: non-constant format string in call to github.com/elastic/elastic-agent-libs/logp.Info FAIL github.com/elastic/elastic-agent-libs/logp [build failed] ```
mauri870
added
Team:Elastic-Agent-Data-Plane
mauri870
requested review from
AndersonQ and
VihasMakwana
and removed request for
a team
Appreciate the review, Lee. I'll open follow ups on elastic-agent and beats as needed since they also have similar failures. |
💚 Build Succeeded
History
cc @mauri870 |
VihasMakwana
pushed a commit
to VihasMakwana/elastic-agent-libs
that referenced
this pull request
Oct 4, 2024
The cmd/vet in Go 1.24 reports printf calls with non-const format and no args, causing one test in logp to fail. See golang/go#60529. ``` $ go install golang.org/dl/gotip@latest $ gotip download $ gotip test ./logp -count=1 logp/core_test.go:714:7: non-constant format string in call to github.com/elastic/elastic-agent-libs/logp.Info FAIL github.com/elastic/elastic-agent-libs/logp [build failed] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The cmd/vet in Go 1.24 reports printf calls with non-const format and no args, causing one test in logp to fail.
See golang/go#60529.
Checklist