Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tlscommon] Make genTest and getFingerPrint methods public #268

Merged
merged 3 commits into from
Jan 28, 2025
Merged

[tlscommon] Make genTest and getFingerPrint methods public #268

merged 3 commits into from
Jan 28, 2025

Conversation

khushijain21
Copy link
Contributor

What does this PR do?

To be able to reuse certain helper methods for beatsauthextension.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Relates elastic/opentelemetry-collector-components#334

@khushijain21 khushijain21 requested a review from a team as a code owner January 24, 2025 16:10
@khushijain21 khushijain21 requested review from belimawr and rdner and removed request for a team January 24, 2025 16:10
mauri870
mauri870 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some minor feedback.

belimawr
belimawr approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I agree with @mauri870's comments/suggestions. It would be nice to have them implemented before merging.

transport/tlscommon/tls_config_test.go Show resolved Hide resolved
transport/tlscommon/tls_config_test.go Outdated Show resolved Hide resolved
@mauri870
Copy link
Member

Thanks!

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@khushijain21 khushijain21 merged commit 46fafcc into elastic:main Jan 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauri870 mauri870 mauri870 approved these changes

@belimawr belimawr belimawr approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khushijain21 @mauri870 @elasticmachine @belimawr