Skip to content

Conversation

@ycombinator
Copy link
Contributor

What does this PR do?

This PR temporarily creates ECH deployments for the FIPS integration testing Buildkite pipeline in the Production CFT ESS environment (as opposed to the Staging GovCloud ESS environment).

Why is it important?

The FIPS integration tests pipeline is currently failing because the step where it provisions deployments in GovCloud Staging is consistently failing.

@ycombinator ycombinator requested a review from a team as a code owner September 17, 2025 16:01
@ycombinator ycombinator added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch labels Sep 17, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

v1v
v1v previously approved these changes Sep 17, 2025
Comment on lines 15 to 19
- vault_ec_key_staging_frh_gov: &vault_ec_key_staging_frh_gov
# - vault_ec_key_staging_frh_gov: &vault_ec_key_staging_frh_gov
# elastic/vault-secrets#v0.1.0:
# path: "kv/ci-shared/platform-ingest/platform-ingest-ec-staging-gov"
# field: "apiKey"
# env_var: "EC_API_KEY"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can keep this YAML anchor, without commenting out, then you just use the other one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought about that but wanted to deliberately comment it out so we know it's being (temporarily) replaced by the other one. I'll add a comment inline explaining that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added explanation in 2c6b4ad.

ebeahan
ebeahan previously approved these changes Sep 17, 2025
v1v
v1v previously approved these changes Sep 17, 2025
@ycombinator
Copy link
Contributor Author

FIPS integration testing steps ran successfully in the last CI run so removing ae0e89d from this PR now. This will let us easily revert the changes in this PR once the Staging GovCloud issues are fixed.

To be clear, we need the change in ae0e89d for the long term, so that's been added in a separate PR: #10008

@ebeahan ebeahan merged commit c76bfe2 into elastic:main Sep 17, 2025
11 of 12 checks passed
mergify bot pushed a commit that referenced this pull request Sep 17, 2025
…tion CFT environment (#10007)

* Have FIPS integration tests spin up deployments in Production CFT environment

* Add explanatory comment

* Run extended tests if FIPS integration tests pipeline changes

* Revert "Run extended tests if FIPS integration tests pipeline changes"

This reverts commit ae0e89d.

(cherry picked from commit c76bfe2)
mergify bot pushed a commit that referenced this pull request Sep 17, 2025
…tion CFT environment (#10007)

* Have FIPS integration tests spin up deployments in Production CFT environment

* Add explanatory comment

* Run extended tests if FIPS integration tests pipeline changes

* Revert "Run extended tests if FIPS integration tests pipeline changes"

This reverts commit ae0e89d.

(cherry picked from commit c76bfe2)
@ycombinator ycombinator deleted the redirect-fips-it branch September 17, 2025 23:08
ycombinator added a commit that referenced this pull request Sep 18, 2025
…tion CFT environment (#10007) (#10011)

* Have FIPS integration tests spin up deployments in Production CFT environment

* Add explanatory comment

* Run extended tests if FIPS integration tests pipeline changes

* Revert "Run extended tests if FIPS integration tests pipeline changes"

This reverts commit ae0e89d.

(cherry picked from commit c76bfe2)

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @ycombinator

cmacknz pushed a commit that referenced this pull request Sep 18, 2025
…tion CFT environment (#10007)

* Have FIPS integration tests spin up deployments in Production CFT environment

* Add explanatory comment

* Run extended tests if FIPS integration tests pipeline changes

* Revert "Run extended tests if FIPS integration tests pipeline changes"

This reverts commit ae0e89d.
v1v pushed a commit that referenced this pull request Sep 18, 2025
intxgo pushed a commit to intxgo/elastic-agent that referenced this pull request Sep 24, 2025
…tion CFT environment (elastic#10007)

* Have FIPS integration tests spin up deployments in Production CFT environment

* Add explanatory comment

* Run extended tests if FIPS integration tests pipeline changes

* Revert "Run extended tests if FIPS integration tests pipeline changes"

This reverts commit ae0e89d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants