-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move queue management to dispatcher #1095
Conversation
This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
NOTE: |
Move queue management actions to the dispatcher from the fleet-server in order to help with future work to add a retry mechanism. Add a PersistedQueue type which wrap the ActionQueue to make persisting the queue simpler for the consumer.
37916b2
to
246e23a
Compare
🌐 Coverage report
|
rebasing on github is mesy I'll make a new PR for v2 without any of the garbage |
This pull request is now in conflicts. Could you fix it? 🙏
|
Uses fixes from the v2 attempt: #1109 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good.
f.log.Error(err.Error()) | ||
actions := make([]fleetapi.Action, len(resp.Actions)) | ||
for idx, a := range resp.Actions { | ||
actions[idx] = a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this forloop copy should work.
copy(actions, resp.Actions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, loop was the original implementation. i'll change to copy
/test |
70efec1
to
d7b34de
Compare
/test |
The Mac build being broken is a known issue and is not specific to this PR, main just updated to switch to Github actions which should help. There is an open investigation with the CI team about why the Mac workers aren't reliable. |
Closing, v2 PR was merged as the feature has been pushed to 8.6 |
What does this PR do?
Move queue management actions to the dispatcher from the fleet-server in order to help with future work to add a retry mechanism. Add a PersistedQueue type which wrap the ActionQueue to make persisting the queue simpler for the consumer.
Queuing was added as part of #419
Why is it important?
Retry actions on edge will be implemented in the dispatcher by interacting with the queue. Moving all of the control flow for the queue to the dispatcher makes it more straightforward to understand and debug
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Follow guide in #419
Related issues