Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.8](backport #2638) Add linting rules for replace directives in go.mod #2698

Merged
merged 1 commit into from
May 16, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 16, 2023

This is an automatic backport of pull request #2638 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add linting rules for `replace` directives in go.mod

* Adding test replace dependencies

* Commenting out local replace

* Run go mod tidy

* Enable the linter

* Add back both test examples

* Removing local example

* Trying out nolint

* Trying again

* Trying another way

* Removing test replace directive

(cherry picked from commit 3aeb206)
@mergify mergify bot requested a review from a team as a code owner May 16, 2023 13:57
@mergify mergify bot requested review from michel-laterman and pchila and removed request for a team May 16, 2023 13:57
@mergify mergify bot added the backport label May 16, 2023
@ycombinator ycombinator enabled auto-merge (squash) May 16, 2023 13:57
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-16T13:57:14.444+0000

  • Duration: 18 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 5673
Skipped 25
Total 5698

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.611% (71/72) 👍
Files 68.273% (170/249) 👍
Classes 66.951% (314/469) 👍
Methods 53.445% (954/1785) 👍
Lines 39.419% (10984/27865) 👎 -0.007
Conditionals 100.0% (0/0) 💚

@ycombinator ycombinator merged commit 80e3a2c into 8.8 May 16, 2023
@ycombinator ycombinator deleted the mergify/bp/8.8/pr-2638 branch May 16, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants