Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right HTTP client #4288

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

rdner
Copy link
Member

@rdner rdner commented Feb 20, 2024

What does this PR do?

Using the default HTTP client was incorrect.

Why is it important?

So, we can correctly configure this request.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in ./changelog/fragments using the changelog tool
    - [ ] I have added an integration test or an E2E test

Related issues

Using the default HTTP client was incorrect.
@rdner rdner added enhancement New feature or request Team:Elastic-Agent Label for the Agent team skip-changelog backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify labels Feb 20, 2024
@rdner rdner self-assigned this Feb 20, 2024
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@rdner rdner marked this pull request as ready for review February 20, 2024 16:03
@rdner rdner requested a review from a team as a code owner February 20, 2024 16:03
@rdner rdner requested review from blakerouse and pchila February 20, 2024 16:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@rdner rdner requested review from AndersonQ and michalpristas and removed request for blakerouse and pchila February 20, 2024 16:35
@rdner rdner enabled auto-merge (squash) February 20, 2024 16:36
@rdner rdner merged commit ed1c28c into elastic:main Feb 20, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
Using the default HTTP client was incorrect.

(cherry picked from commit ed1c28c)
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
Using the default HTTP client was incorrect.

(cherry picked from commit ed1c28c)
@rdner rdner deleted the replace-http-client-artifact-api branch February 21, 2024 08:59
rdner added a commit that referenced this pull request Feb 21, 2024
Using the default HTTP client was incorrect.

(cherry picked from commit ed1c28c)

Co-authored-by: Denis <denis.rechkunov@elastic.co>
rdner added a commit that referenced this pull request Feb 22, 2024
Using the default HTTP client was incorrect.

(cherry picked from commit ed1c28c)

Co-authored-by: Denis <denis.rechkunov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants