Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix logs integration test #6069

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[CI] Fix logs integration test #6069

merged 1 commit into from
Nov 19, 2024

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Nov 18, 2024 •
edited
Loading

What does this PR do?

Fixes logs integration test by ignoring the error with GCP.
Addition to #6031

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Nov 18, 2024
@pazone pazone requested a review from a team as a code owner November 18, 2024 21:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mergify mergify bot assigned pazone Nov 18, 2024
@pazone pazone mentioned this pull request Nov 18, 2024
Merged
7 tasks
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@pazone pazone merged commit 574ec32 into main Nov 19, 2024
19 checks passed
@pazone pazone deleted the ci_integration_tests_fix_gcp_error branch November 19, 2024 10:59
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
@pazone @mergify
Fix logs integration test (#6069)
ac87780 
(cherry picked from commit 574ec32)

# Conflicts:
#	testing/integration/logs_ingestion_test.go
@mergify mergify bot mentioned this pull request Nov 19, 2024
Open
7 tasks
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
@pazone @mergify
Fix logs integration test (#6069)
0f6c1bb 
(cherry picked from commit 574ec32)
This was referenced Nov 19, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaanyalti kaanyalti kaanyalti approved these changes

@cmacknz cmacknz cmacknz approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@pazone pazone

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pazone @elasticmachine @cmacknz @kaanyalti