-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an indicative limit for judging if a PR is too big in PR guidelines #6128
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @pchila? 🙏
|
|
I'm also adding folks from my team as we are working also on the Agent repository. |
@ycombinator: Let's wait till at least 2/3 of the reviewers tagged on this PR have approved it. It's an unusually high bar but I'd rather we clear that first than have pushback later.
What does this PR do?
Add indications about expected size of PRs in CONTRIBUTING.md
Why is it important?
To improve code review experience.
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself