Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an indicative limit for judging if a PR is too big in PR guidelines #6128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pchila
Copy link
Member

@pchila pchila commented Nov 22, 2024

@ycombinator: Let's wait till at least 2/3 of the reviewers tagged on this PR have approved it. It's an unusually high bar but I'd rather we clear that first than have pushback later.

What does this PR do?

Add indications about expected size of PRs in CONTRIBUTING.md

Why is it important?

To improve code review experience.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added documentation Improvements or additions to documentation chore Tasks that just need to be done, they are neither bug, nor enhancements labels Nov 22, 2024
@pchila pchila self-assigned this Nov 22, 2024
@pchila pchila requested a review from a team as a code owner November 22, 2024 14:24
Copy link
Contributor

mergify bot commented Nov 22, 2024

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 22, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 22, 2024
@pierrehilbert
Copy link
Contributor

I'm also adding folks from my team as we are working also on the Agent repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify chore Tasks that just need to be done, they are neither bug, nor enhancements documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants