-
Notifications
You must be signed in to change notification settings - Fork 204
fix install prevention on Linux #6866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request does not have a backport label. Could you fix it @intxgo? 🙏
|
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
/test |
comment from Panos needs to be addressed
|
/test |
5140c2c to
197e0a1
Compare
|
pkoutsovasilis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes look good to me. Waiting for the CI to complete just to strengthen my understanding of specs/endpoint-security.spec.yml that we are not breaking any IT (integration tests)
* fix install prevention on Linux * changelog * remove changelog fragment as the bug didn't land in any release yet * upgate go-sysinfo module * go mod tidy * notice * CRLF to LF (cherry picked from commit f7fc674)
* fix install prevention on Linux * changelog * remove changelog fragment as the bug didn't land in any release yet * upgate go-sysinfo module * go mod tidy * notice * CRLF to LF (cherry picked from commit f7fc674)
* fix install prevention on Linux * changelog * remove changelog fragment as the bug didn't land in any release yet * upgate go-sysinfo module * go mod tidy * notice * CRLF to LF (cherry picked from commit f7fc674)
* fix install prevention on Linux * changelog * remove changelog fragment as the bug didn't land in any release yet * upgate go-sysinfo module * go mod tidy * notice * CRLF to LF (cherry picked from commit f7fc674) Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>
* fix install prevention on Linux * changelog * remove changelog fragment as the bug didn't land in any release yet * upgate go-sysinfo module * go mod tidy * notice * CRLF to LF (cherry picked from commit f7fc674) Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>
* fix install prevention on Linux * changelog * remove changelog fragment as the bug didn't land in any release yet * upgate go-sysinfo module * go mod tidy * notice * CRLF to LF (cherry picked from commit f7fc674) Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>





What does this PR do?
go-sysinfodetermines native architecture based on/procfilesystem which could be disabled, therefore the prevention should err on allowing installation when native architecture is unknown.The fixed prevention was not included in any released version yet.
Why is it important?
Agent prevents adding Elastic Defend when it cannot determine if it's being emulated. However it's fine to install Elastic Defend in such case, as it does emulation check on it's own upon installation returning installation error when appropriate.
Checklist
./changelog/fragmentsusing the changelog toolRelated issues