Skip to content

Conversation

@intxgo
Copy link
Contributor

@intxgo intxgo commented Feb 14, 2025

What does this PR do?

go-sysinfo determines native architecture based on /proc filesystem which could be disabled, therefore the prevention should err on allowing installation when native architecture is unknown.

The fixed prevention was not included in any released version yet.

Why is it important?

Agent prevents adding Elastic Defend when it cannot determine if it's being emulated. However it's fine to install Elastic Defend in such case, as it does emulation check on it's own upon installation returning installation error when appropriate.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

@intxgo intxgo added the bug Something isn't working label Feb 14, 2025
@intxgo intxgo marked this pull request as ready for review February 14, 2025 10:19
@intxgo intxgo requested a review from a team as a code owner February 14, 2025 10:19
@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

This pull request does not have a backport label. Could you fix it @intxgo? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@mergify mergify bot assigned intxgo Feb 14, 2025
@intxgo intxgo added backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch skip-changelog labels Feb 14, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 14, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@intxgo intxgo enabled auto-merge (squash) February 17, 2025 09:10
@intxgo
Copy link
Contributor Author

intxgo commented Feb 17, 2025

/test

kaanyalti
kaanyalti previously approved these changes Feb 17, 2025
@kaanyalti kaanyalti self-requested a review February 17, 2025 21:01
@kaanyalti kaanyalti dismissed their stale review February 17, 2025 21:03

comment from Panos needs to be addressed

@intxgo
Copy link
Contributor Author

intxgo commented Feb 18, 2025

/test

@intxgo intxgo force-pushed the fix-install-prevention-on-linux branch from 5140c2c to 197e0a1 Compare February 18, 2025 11:58
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good to me. Waiting for the CI to complete just to strengthen my understanding of specs/endpoint-security.spec.yml that we are not breaking any IT (integration tests)

@intxgo intxgo merged commit f7fc674 into elastic:main Feb 19, 2025
14 checks passed
mergify bot pushed a commit that referenced this pull request Feb 19, 2025
* fix install prevention on Linux

* changelog

* remove changelog fragment as the bug didn't land in any release yet

* upgate go-sysinfo module

* go mod tidy

* notice

* CRLF to LF

(cherry picked from commit f7fc674)
mergify bot pushed a commit that referenced this pull request Feb 19, 2025
* fix install prevention on Linux

* changelog

* remove changelog fragment as the bug didn't land in any release yet

* upgate go-sysinfo module

* go mod tidy

* notice

* CRLF to LF

(cherry picked from commit f7fc674)
mergify bot pushed a commit that referenced this pull request Feb 19, 2025
* fix install prevention on Linux

* changelog

* remove changelog fragment as the bug didn't land in any release yet

* upgate go-sysinfo module

* go mod tidy

* notice

* CRLF to LF

(cherry picked from commit f7fc674)
@intxgo intxgo deleted the fix-install-prevention-on-linux branch February 19, 2025 10:12
intxgo added a commit that referenced this pull request Feb 19, 2025
* fix install prevention on Linux

* changelog

* remove changelog fragment as the bug didn't land in any release yet

* upgate go-sysinfo module

* go mod tidy

* notice

* CRLF to LF

(cherry picked from commit f7fc674)

Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>
intxgo added a commit that referenced this pull request Feb 19, 2025
* fix install prevention on Linux

* changelog

* remove changelog fragment as the bug didn't land in any release yet

* upgate go-sysinfo module

* go mod tidy

* notice

* CRLF to LF

(cherry picked from commit f7fc674)

Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>
intxgo added a commit that referenced this pull request Feb 19, 2025
* fix install prevention on Linux

* changelog

* remove changelog fragment as the bug didn't land in any release yet

* upgate go-sysinfo module

* go mod tidy

* notice

* CRLF to LF

(cherry picked from commit f7fc674)

Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch bug Something isn't working skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants