Skip to content

Revert "Switch to NewGCMWithRandomNonce for fips (#7474)" #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

michel-laterman
Copy link
Contributor

Revert "Switch to NewGCMWithRandomNonce for fips (#7474)"

aes.Block typecheck fails when built with microsoft/go due to the boring crypto patch used by microsoft.

This is likely an occurrence of an upstream issue

@michel-laterman michel-laterman added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Apr 7, 2025
@michel-laterman michel-laterman requested a review from a team as a code owner April 7, 2025 20:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

mergify bot commented Apr 7, 2025

This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@michel-laterman
Copy link
Contributor Author

8.x revert: #7740

Copy link

@michel-laterman michel-laterman merged commit 8ff2c18 into main Apr 9, 2025
13 of 16 checks passed
@michel-laterman michel-laterman deleted the revert-7474-fips-random-nonce branch April 9, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants