Skip to content

Conversation

@andrzej-stencel
Copy link
Contributor

Without it, mage notice fails, because mage tidy fails, because magefile cannot be compiled, because the root go.mod file that Mage depends on is out of date.

Related to #8279, discussed with @pkoutsovasilis.

Steps to reproduce the issue

  1. Pull latest main
  2. Run .ci/scripts/otel-update.sh v0.127.0 v1.33.0, or make some other change in the root go.mod that invalidates go.sum.

Expected result:

  • The otel-update.sh scripts / mage tidy succeeds

Actual result:

  • The otel-update.sh script fails with error compiling magefiles
$ .ci/scripts/otel-update.sh v0.127.0 v1.33.0
=> Updating core from v0.123.0/v1.29.0 to v0.127.0/v1.33.0
=> Updating contrib from v0.123.0 to v0.127.0
=> Running mage notice
internal/pkg/config/config.go:13:2: missing go.sum entry for module providing package go.opentelemetry.io/collector/confmap (imported by github.com/elastic/elastic-agent/internal/pkg/config); to add:
        go get github.com/elastic/elastic-agent/internal/pkg/config
Error: error compiling magefiles
$

Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.
@andrzej-stencel andrzej-stencel requested review from a team as code owners June 4, 2025 08:02
@andrzej-stencel andrzej-stencel added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-active-all Automated backport with mergify to all the active branches labels Jun 4, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

andrzej-stencel added a commit to andrzej-stencel/elastic-agent that referenced this pull request Jun 4, 2025
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for handling this, LGTM

@pkoutsovasilis
Copy link
Contributor

@v1v @pazone sorry for the tag bug could we please get a review here?

@andrzej-stencel andrzej-stencel merged commit bb6eff4 into main Jun 5, 2025
12 checks passed
@andrzej-stencel andrzej-stencel deleted the fix-otel-update-script branch June 5, 2025 11:20
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

@Mergifyio backport 8.17 8.18 8.19 9.0

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2025

mergify bot pushed a commit that referenced this pull request Jun 5, 2025
Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.

(cherry picked from commit bb6eff4)
mergify bot pushed a commit that referenced this pull request Jun 5, 2025
Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.

(cherry picked from commit bb6eff4)
mergify bot pushed a commit that referenced this pull request Jun 5, 2025
Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.

(cherry picked from commit bb6eff4)
mergify bot pushed a commit that referenced this pull request Jun 5, 2025
Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.

(cherry picked from commit bb6eff4)
v1v added a commit to v1v/elastic-agent that referenced this pull request Jun 5, 2025
* main:
  Remove cloudbeat from CODEOWNERS (elastic#8336)
  fix(ci): restore `go mod tidy` in `otel-update.sh` script (elastic#8326)
  ci: update all n1-standard-4 type runners to n2-standard-4 (elastic#8340)
  build(deps): bump github.com/elastic/go-concert from 0.3.0 to 0.3.1 (elastic#8313)
  ci: add retries when rendering kustomize (elastic#8321)
  [main][Automation] Update versions (elastic#8318)
  feat: generate a subject key identifier when creating a certificate (elastic#6379)
  otel: support system/metrics input with experimental otel runtime (elastic#8148)
  ci: update all n1-standard-8 type runners to n2-standard-8 (elastic#8320)
  build(deps): bump github.com/elastic/elastic-agent-libs from 0.19.5 to 0.19.6 (elastic#8283)
andrzej-stencel added a commit that referenced this pull request Jun 9, 2025
* automatically update OTel components

Creates a new GitHub Actions workflow that runs Updatecli daily to check if a new version of OTel components is available. If it is, Updatecli runs the `update-otel.sh` script and creates a new PR with the changes.

These automated updates are currently configured to run for the `main` branch and for the `8.19` branch.

* restore `go mod tidy` in `update-otel.sh`

Forward-porting #8326

* fix: install changelog tool if missing

* fix: add missing env vars to Updatecli target config

* define branch matrix as a static list

* run Updatecli script from the main branch
mergify bot pushed a commit that referenced this pull request Jun 9, 2025
* automatically update OTel components

Creates a new GitHub Actions workflow that runs Updatecli daily to check if a new version of OTel components is available. If it is, Updatecli runs the `update-otel.sh` script and creates a new PR with the changes.

These automated updates are currently configured to run for the `main` branch and for the `8.19` branch.

* restore `go mod tidy` in `update-otel.sh`

Forward-porting #8326

* fix: install changelog tool if missing

* fix: add missing env vars to Updatecli target config

* define branch matrix as a static list

* run Updatecli script from the main branch

(cherry picked from commit 7766913)
andrzej-stencel added a commit that referenced this pull request Jun 9, 2025
)

Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.

(cherry picked from commit bb6eff4)

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel added a commit that referenced this pull request Jun 9, 2025
)

Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.

(cherry picked from commit bb6eff4)

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel added a commit that referenced this pull request Jun 9, 2025
)

Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.

(cherry picked from commit bb6eff4)

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel added a commit that referenced this pull request Jun 9, 2025
)

Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.

(cherry picked from commit bb6eff4)

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel added a commit that referenced this pull request Jun 9, 2025
* automatically update OTel components

Creates a new GitHub Actions workflow that runs Updatecli daily to check if a new version of OTel components is available. If it is, Updatecli runs the `update-otel.sh` script and creates a new PR with the changes.

These automated updates are currently configured to run for the `main` branch and for the `8.19` branch.

* restore `go mod tidy` in `update-otel.sh`

Forward-porting #8326

* fix: install changelog tool if missing

* fix: add missing env vars to Updatecli target config

* define branch matrix as a static list

* run Updatecli script from the main branch

(cherry picked from commit 7766913)

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
michel-laterman pushed a commit to michel-laterman/elastic-agent that referenced this pull request Jun 9, 2025
* automatically update OTel components

Creates a new GitHub Actions workflow that runs Updatecli daily to check if a new version of OTel components is available. If it is, Updatecli runs the `update-otel.sh` script and creates a new PR with the changes.

These automated updates are currently configured to run for the `main` branch and for the `8.19` branch.

* restore `go mod tidy` in `update-otel.sh`

Forward-porting elastic#8326

* fix: install changelog tool if missing

* fix: add missing env vars to Updatecli target config

* define branch matrix as a static list

* run Updatecli script from the main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants