-
Notifications
You must be signed in to change notification settings - Fork 204
fix(ci): restore go mod tidy in otel-update.sh script
#8326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
andrzej-stencel
added a commit
to andrzej-stencel/elastic-agent
that referenced
this pull request
Jun 4, 2025
Forward-porting elastic#8326
pkoutsovasilis
approved these changes
Jun 4, 2025
Contributor
pkoutsovasilis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for handling this, LGTM
Contributor
v1v
approved these changes
Jun 4, 2025
pazone
approved these changes
Jun 5, 2025
Contributor
|
@Mergifyio backport 8.17 8.18 8.19 9.0 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2025
Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date. (cherry picked from commit bb6eff4)
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2025
Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date. (cherry picked from commit bb6eff4)
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2025
Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date. (cherry picked from commit bb6eff4)
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2025
Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date. (cherry picked from commit bb6eff4)
v1v
added a commit
to v1v/elastic-agent
that referenced
this pull request
Jun 5, 2025
* main: Remove cloudbeat from CODEOWNERS (elastic#8336) fix(ci): restore `go mod tidy` in `otel-update.sh` script (elastic#8326) ci: update all n1-standard-4 type runners to n2-standard-4 (elastic#8340) build(deps): bump github.com/elastic/go-concert from 0.3.0 to 0.3.1 (elastic#8313) ci: add retries when rendering kustomize (elastic#8321) [main][Automation] Update versions (elastic#8318) feat: generate a subject key identifier when creating a certificate (elastic#6379) otel: support system/metrics input with experimental otel runtime (elastic#8148) ci: update all n1-standard-8 type runners to n2-standard-8 (elastic#8320) build(deps): bump github.com/elastic/elastic-agent-libs from 0.19.5 to 0.19.6 (elastic#8283)
andrzej-stencel
added a commit
that referenced
this pull request
Jun 9, 2025
* automatically update OTel components Creates a new GitHub Actions workflow that runs Updatecli daily to check if a new version of OTel components is available. If it is, Updatecli runs the `update-otel.sh` script and creates a new PR with the changes. These automated updates are currently configured to run for the `main` branch and for the `8.19` branch. * restore `go mod tidy` in `update-otel.sh` Forward-porting #8326 * fix: install changelog tool if missing * fix: add missing env vars to Updatecli target config * define branch matrix as a static list * run Updatecli script from the main branch
mergify bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
* automatically update OTel components Creates a new GitHub Actions workflow that runs Updatecli daily to check if a new version of OTel components is available. If it is, Updatecli runs the `update-otel.sh` script and creates a new PR with the changes. These automated updates are currently configured to run for the `main` branch and for the `8.19` branch. * restore `go mod tidy` in `update-otel.sh` Forward-porting #8326 * fix: install changelog tool if missing * fix: add missing env vars to Updatecli target config * define branch matrix as a static list * run Updatecli script from the main branch (cherry picked from commit 7766913)
andrzej-stencel
added a commit
that referenced
this pull request
Jun 9, 2025
) Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date. (cherry picked from commit bb6eff4) Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel
added a commit
that referenced
this pull request
Jun 9, 2025
) Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date. (cherry picked from commit bb6eff4) Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel
added a commit
that referenced
this pull request
Jun 9, 2025
) Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date. (cherry picked from commit bb6eff4) Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel
added a commit
that referenced
this pull request
Jun 9, 2025
) Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date. (cherry picked from commit bb6eff4) Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel
added a commit
that referenced
this pull request
Jun 9, 2025
* automatically update OTel components Creates a new GitHub Actions workflow that runs Updatecli daily to check if a new version of OTel components is available. If it is, Updatecli runs the `update-otel.sh` script and creates a new PR with the changes. These automated updates are currently configured to run for the `main` branch and for the `8.19` branch. * restore `go mod tidy` in `update-otel.sh` Forward-porting #8326 * fix: install changelog tool if missing * fix: add missing env vars to Updatecli target config * define branch matrix as a static list * run Updatecli script from the main branch (cherry picked from commit 7766913) Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
michel-laterman
pushed a commit
to michel-laterman/elastic-agent
that referenced
this pull request
Jun 9, 2025
* automatically update OTel components Creates a new GitHub Actions workflow that runs Updatecli daily to check if a new version of OTel components is available. If it is, Updatecli runs the `update-otel.sh` script and creates a new PR with the changes. These automated updates are currently configured to run for the `main` branch and for the `8.19` branch. * restore `go mod tidy` in `update-otel.sh` Forward-porting elastic#8326 * fix: install changelog tool if missing * fix: add missing env vars to Updatecli target config * define branch matrix as a static list * run Updatecli script from the main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-active-all
Automated backport with mergify to all the active branches
skip-changelog
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it,
mage noticefails, becausemage tidyfails, because magefile cannot be compiled, because the rootgo.modfile that Mage depends on is out of date.Related to #8279, discussed with @pkoutsovasilis.
Steps to reproduce the issue
main.ci/scripts/otel-update.sh v0.127.0 v1.33.0, or make some other change in the rootgo.modthat invalidatesgo.sum.Expected result:
otel-update.shscripts /mage tidysucceedsActual result:
otel-update.shscript fails witherror compiling magefiles