Refactor user change on service #8347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
Team:Elastic-Agent-Control-Plane
Collaborator
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
pchila
reviewed
Jun 5, 2025
Contributor
Author
|
need to figure out some Server vs Home behavior differences |
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
blakerouse
approved these changes
Jul 3, 2025
Contributor
blakerouse
left a comment
blakerouse
left a comment
There was a problem hiding this comment.
Looks good. Thanks for working through the code review.
|
Collaborator
💚 Build Succeeded
History
|
Contributor
|
@Mergifyio backport 9.0 9.1 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
(cherry picked from commit f942cf9) # Conflicts: # NOTICE-fips.txt # go.mod
mergify bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
(cherry picked from commit f942cf9)
v1v
added a commit
that referenced
this pull request
Jul 6, 2025
* upstream: (39 commits) Fix otel extension status reporting (#8696) Refactor user change on service (#8347) [AutoOps] Add `autoops-es.yml` to Packages (#8728) EDOT collector: include the forward connector. (#8753) Revert "ci: pin elastic-agent version (#8736)" (#8754) bk: retry Start ESS stack for integration tests (#8553) Re-enable TestStandaloneUpgradeRollbackOnRestarts on windows (#8718) removed reviewers from dependabot.yml (#8709) Pass `--header` enrollment option to fleet-server (#8071) Add ability for local output configuration to add to policy configuration (#8766) Bump up github.com/go-viper/mapstructure/v2 dependency (#8764) [Synthetics] Upgrade node to latest lts v20 (#8712) [CI] BK Vault plugin for EC access (#8377) feat: singleTest mage target for each integration test package (#8691) ci: always include 8.19 LTS release branch in snapshots of test versions (#8761) build(deps): bump github.com/elastic/mito from 1.19.0 to 1.20.0 (#8755) chore: fix elastic-agent helm chart examples (#8765) feat: support onboarding-id for kubernetes (#8692) [main][Automation] Bump VM Image version to 1751072471 (#8734) ci: revert deployment_csp_configuration.yaml to create_deployment_csp_configuration.yaml (#8746) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the way how we do User change during
unprivilegedandprivilegedactions.Pre-PR we removed and reinstalled service again with new user setup.
Post-PR we rewrite service file directly (linux and darwin) or use syscall to change config (windows). Then we restart service.
This reduces window for interrupt.
While pre-PR could leave us without a service, in this case we haven't won entirely. We can end up with broken service when service manager decides config/user is not valid/enabled. This at least leaves a trace in system logs.
Tests covering switch between privilege modes are already present
Closes: #8268